Repository navigation
Set a good eslint config #38
Description
Activity
I think whole repo should be split into several submodules, one for each example, and each one having its own set of ESLint rules. In the end, we'll be able to remove ESLint from this master project, and have it independently on each submodule.
How having several submodules would help with the ESLint rules?
- Each one will have his own, relevant, set of rules. It will also be easier to fix the linting issue one submodule at a time On Wed, Mar 15, 2017 at 12:56am, Alexandre Collin < notifications@github.com [notifications@github.com] > wrote: How having several submodules would help with the ESLint rules? — You are receiving this because you commented. Reply to this email directly, view it on GitHub [#38 (comment)] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AARTG0T_uGWgfWuoiyHsTsGg8TdqJEdVks5rlykVgaJpZM4MbL6R] .
Each one will have his own, relevant, set of rules. It will also be easier to fix the linting issue one submodule at a time
For easing the contribution, we should go for a single unified configuration. However I agree that we don't need to do that in a single iteration. Having configuration per project then moving to a single one feels like the best way to ensure we are moving forward.
Reacted by Haroen Viaene
ESlint is enforced in this project but:
If we want to continue using eslint we need a virtuous circle where the project is clean before and when there is a PR it will have to follow because it was clean before :)