Complete Tailwind migration for landing experience and shared form styles#123
Complete Tailwind migration for landing experience and shared form styles#123algobasket wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccded78442
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # | ||
| #= require bootstrap | ||
| #= require bootstrap-switch.min | ||
| # |
There was a problem hiding this comment.
Re-add bootstrap-switch to market asset bundle
Removing #= require bootstrap-switch.min from the market manifest breaks page initialization because market code still calls bootstrapSwitch in both app/assets/javascripts/lib/notifier.js.coffee (constructor) and app/assets/javascripts/component_ui/header.js.coffee (@after 'initialize'). Since new Notifier() runs immediately in market.js.coffee, market pages now raise $(...).bootstrapSwitch is not a function and stop attaching core trading components.
Useful? React with 👍 / 👎.
| //= require jquery_ujs | ||
| //= require bootstrap | ||
| //= require bootstrap-wysihtml5/b3 | ||
| //= require bootstrap-datetimepicker | ||
| //= require ZeroClipboard |
There was a problem hiding this comment.
Restore wysihtml5 plugin include for admin document forms
The admin documents form still initializes a rich-text editor via $(elem).wysihtml5(...) in app/views/admin/documents/_form.html.slim, but this manifest change removed //= require bootstrap-wysihtml5/b3, so the jQuery plugin is no longer registered. On document create/edit pages this causes $(...).wysihtml5 is not a function, leaving the form with a runtime error instead of the expected editor.
Useful? React with 👍 / 👎.
Motivation
Description
app/views/welcome/index.html.slim) with a Tailwind-first hero, improved hierarchy, and clear CTAs for authenticated and anonymous users.app/views/shared/_alert.html.slim,app/views/shared/_footer.html.slim) to Tailwind utility classes and replaced Bootstrap dismiss semantics with simple DOM removal controls.https://cdn.tailwindcss.com) into main layouts (application,landing,admin,api_v2,funds) and removed Bootstrap asset imports and JS requires from several manifests/stylesheets (app/assets/javascripts/*,app/assets/stylesheets/*,admin.css.scss,application.css.scss,market.css.scss,api_v2.css.scss).config/initializers/simple_form.rb,config/initializers/simple_form_bootstrap.rb) to emit utility classes and aspace-y-5form default while retaining compatibility wrapper names.README.mdnote about Tailwind + Dependabot config (.github/dependabot.yml) and a Dependency Review workflow (.github/workflows/dependency-review.yml).Testing
rgto confirm removed usage in the touched files and found no remaining references in those files (search passed).ruby -c config/initializers/simple_form.rbandruby -c config/initializers/simple_form_bootstrap.rb(both returnedSyntax OK).bundle exec rails server -p 3000, which failed due to missing bundled executables (bundlerenvironment lacks installed gems), so runtime verification could not complete.http://127.0.0.1:3000, which failed withnet::ERR_EMPTY_RESPONSEbecause the Rails server was not running in this environment.Codex Task