build: adopt gotmpl4j 1.0.0#507
Merged
Merged
Conversation
gotmpl4j cut its stable 1.0.0 release. Bump the engine dependency from 0.3.0 to the 1.0.0 GA on Maven Central. jhelm's pre-release compatibility review (issues alexmond/gotmpl4j#48, #49) was resolved before the tag: - exception hierarchy unified under one unchecked root (gotmpl4j#49) — jhelm's FunctionExecutionException / TemplateException usage is unaffected; - the low-level getRootNodes()/getFunctions() getters were carved out of the 1.0 stability guarantee (gotmpl4j#48, option b) — jhelm's node-map usage keeps working; a first-class replacement is tracked for post-1.0. Verified against the published 1.0.0 artifact: jhelm-core + jhelm-gotemplate-helm build and unit tests green; 346/346 chart byte-parity unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U5yvjG89AqMHPAGJawSmg9
Contributor
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the engine dependency from gotmpl4j 0.3.0 → 1.0.0 (now GA on Maven Central).
The pre-release compatibility review was resolved before gotmpl4j tagged 1.0:
GoTemplateException). jhelm'sFunctionExecutionException(4 files) andTemplateException(1 test) usage is unaffected (now-unchecked →catch/assertThrowsstill compile).getRootNodes()/getFunctions()getters were carved out of the 1.0 stability guarantee (option b). jhelm's 9 node-map call sites keep working; a first-class replacement is tracked there for post-1.0.Verification (against the published 1.0.0 artifact)
jhelm-core+jhelm-gotemplate-helmbuild + unit tests greenOne-line dependency bump. The starter changes in gotmpl4j 1.0 don't affect jhelm (it uses
gotmpl4j-core+gotmpl4j-sprig, not the starter).🤖 Generated with Claude Code