Skip to content

Changed plot_stamps from html to matplotlib, changed mask to psf#69

Merged
ale-munozarancibia merged 2 commits into
mainfrom
fix/plot_stamps_matplotlib
Mar 4, 2026
Merged

Changed plot_stamps from html to matplotlib, changed mask to psf#69
ale-munozarancibia merged 2 commits into
mainfrom
fix/plot_stamps_matplotlib

Conversation

@ale-munozarancibia

Copy link
Copy Markdown
Contributor

Description

This PR changes the multisurvey plot_stamps function from html to matplotlib, because of known problems of the html display on notebooks shown in github and colab. It also renames the include_variance_and_mask flag to include_variance_and_psf, because the third image cutouts plane is PSF and not a mask.

How Has This Been Tested?

Manually in example notebooks

@ale-munozarancibia ale-munozarancibia added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit 5ac1c6f Mar 4, 2026
1 check passed
@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.27%. Comparing base (395d526) to head (b9b1e43).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
alerce/ms_stamps.py 25.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   81.92%   81.27%   -0.66%     
==========================================
  Files          12       12              
  Lines         747      753       +6     
==========================================
  Hits          612      612              
- Misses        135      141       +6     
Files with missing lines Coverage Δ
alerce/common_stamps.py 75.00% <ø> (ø)
alerce/ms_stamp_utils.py 80.00% <ø> (+8.57%) ⬆️
alerce/ms_stamps.py 53.84% <25.00%> (-3.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395d526...b9b1e43. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants