Improve Test Coverage for packages/web3/src/utils#468
Open
Benjtalkshow wants to merge 6 commits into
Open
Conversation
Author
|
@polarker please review |
Member
|
Thanks for the contribution. Please make sure all the updated test suite pass, right now all of them have failing tests. You can run them by |
Author
Alright ser |
Author
|
@h0ngcha0 Will update my PR Soon |
Author
|
Author
|
@h0ngcha0 Please review. |
h0ngcha0
reviewed
Dec 3, 2024
Author
|
@h0ngcha0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #457
Improve Test Coverage for packages/web3/src/utils
Overview
This pull request significantly enhances the test coverage for the
utils.tsfile and other utility functions in thepackages/web3/src/utilsdirectory. We've added new test cases, improved existing ones, and created new test files to ensure comprehensive coverage of our utility functions.Main Changes
utils.test.ts
bs58.test.ts
isBase58function:base58ToBytesfunction:bs58object:djb2.test.ts
djb2function:subscription.test.ts (New File)
Subscriptionclass:TestSubscriptionto test abstractSubscriptionclassAdditional Notes
utils.tsresolve type errors related to theSignatureInputtypesubscription.test.tsprovides thorough coverage for theSubscriptionclass