feat: display node hash on CRN and CCN detail pages#222
Conversation
Add a NODE HASH field with copy-to-clipboard button below the ADDRESS field on CRN pages and below the MULTI ADDRESS field on CCN pages.
foxpatch-aleph
left a comment
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This PR correctly adds a NODE HASH field with copy-to-clipboard functionality to both CRN and CCN detail pages. The implementation follows existing code patterns: it uses the established node.hash property (widely used throughout the codebase), properly imports and uses the existing NodeDetailLink component with the textToCopy prop, and applies ellipseAddress for consistent address formatting. The placement is logical (after ADDRESS for CRN, after MULTI ADDRESS for CCN), and the optional chaining (node?.hash && ...) handles edge cases safely. No security concerns or bugs identified.
amalcaraz
left a comment
amalcaraz
left a comment
There was a problem hiding this comment.
LGTM but main branch is legacy app, we need to open a new PR to merge this into feat/credit-ui as well
3 participants
Add a NODE HASH field with copy-to-clipboard button below the ADDRESS field on CRN pages and below the MULTI ADDRESS field on CCN pages.