Fix: good format when using diagVM #2
Merged
Merged
Conversation
aliel
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the way IPv6 status is fetched and handled for nodes, ensuring compatibility with different node versions and providing a fallback mechanism. The main enhancement is the introduction of version-aware logic for selecting the appropriate IPv6 check endpoint, which increases reliability across nodes running different software versions.
Key changes:
IPv6 Fetching Logic
fetch_ipv6_from_diagandget_ipv6_fetch_methodmethods to select the correct IPv6 fetch method based on the node's cached version, defaulting to a diagnostic endpoint for older or unrecognized versions.get_ipv6_fetch_methodwhen scheduling IPv6 checks for all nodes, ensuring the correct endpoint is used dynamically.Endpoint Constants
CRN_PATH_IPv6_CHECKandDIAG_VM_PATH_IPv6_CHECKto clearly distinguish between the standard and diagnostic IPv6 check endpoints.Error Handling and Defaults
CheckIPv6(host=False, vm=False)object is returned, preventing null values in the output.Dependency
packaginglibrary import to support version parsing for the new version-aware logic.