Skip to content

Fix: good format when using diagVM #2

Merged
1yam merged 5 commits into
mainfrom
1yam-fix-ipv6_check
Jan 16, 2026
Merged

Fix: good format when using diagVM #2
1yam merged 5 commits into
mainfrom
1yam-fix-ipv6_check

Conversation

@1yam

@1yam 1yam commented Jan 16, 2026

Copy link
Copy Markdown
Member

This pull request introduces improvements to the way IPv6 status is fetched and handled for nodes, ensuring compatibility with different node versions and providing a fallback mechanism. The main enhancement is the introduction of version-aware logic for selecting the appropriate IPv6 check endpoint, which increases reliability across nodes running different software versions.

Key changes:

IPv6 Fetching Logic

  • Added fetch_ipv6_from_diag and get_ipv6_fetch_method methods to select the correct IPv6 fetch method based on the node's cached version, defaulting to a diagnostic endpoint for older or unrecognized versions.
  • Updated the code to use the new get_ipv6_fetch_method when scheduling IPv6 checks for all nodes, ensuring the correct endpoint is used dynamically.

Endpoint Constants

  • Introduced new constants CRN_PATH_IPv6_CHECK and DIAG_VM_PATH_IPv6_CHECK to clearly distinguish between the standard and diagnostic IPv6 check endpoints.

Error Handling and Defaults

  • Improved handling in the API response to ensure that if IPv6 check data is missing, a default CheckIPv6(host=False, vm=False) object is returned, preventing null values in the output.

Dependency

  • Added the packaging library import to support version parsing for the new version-aware logic.

@1yam 1yam merged commit ba8dd3b into main Jan 16, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants