-
Notifications
You must be signed in to change notification settings - Fork 12
Dynamic rendering #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KorrAn34
wants to merge
19
commits into
alegian:0.13
Choose a base branch
from
KorrAn34:dynamic-rendering
base: 0.13
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5502150
Reapply "Very WIP dynamic research entry rendering"
KorrAn34 7d82309
Progress towards dynamic rendering mainly EntryScreen.kt
KorrAn34 557d77e
More progress towards dynamic, made DynamicRenderingHelper.kt
KorrAn34 2f1f233
Theory of dynamic rendering finished, time to test
KorrAn34 c2bb5d0
Test#1 actually registered PageFeatureTypes, but getting null font
KorrAn34 3cd12c9
Basic paragraph and title dynamic rendering done, polishing and figur…
KorrAn34 abb15b9
I actually did it, adjustable font size has got nothing on me!
KorrAn34 a9ea121
Adjustable font size done, need to discuss config options.
KorrAn34 ee75d87
PR feedback round 1
KorrAn34 70d7a13
add a beta recipe renderer
alegian 2d03f21
inline relativeCenteredRenderable
alegian 0b8170d
Merge branch '0.13' into dynamic-rendering
alegian f69c465
merge fixes
alegian 9465e01
Merge branch '0.13' into dynamic-rendering
alegian 0b6702b
revert after merge
alegian 0e0ab82
Updated unwieldy function in LanguageProvider
KorrAn34 32f9dbe
Merge branch 'dynamic-rendering' of https://github.com/KorrAn34/thavm…
KorrAn34 466a2c9
Updated unwieldy function in LanguageProvider 2
KorrAn34 c985bfb
Addressed dubious maxWidth and maxHeight in EntryScreen.kt
KorrAn34 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "count": 1, | ||
| "id": "thavma:crucible" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| 0, | ||
| 0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "count": 1, | ||
| "id": "thavma:crucible" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| -2, | ||
| 2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "count": 1, | ||
| "id": "thavma:infusion_matrix" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| 2, | ||
| 2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |
| "count": 1, | ||
| "id": "thavma:aqua_shard" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| 2, | ||
| -4 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "count": 1, | ||
| "id": "thavma:research_table" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| -1, | ||
| -1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ | |
| "count": 1, | ||
| "id": "thavma:goggles" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| 2, | ||
| 4 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ | |
| "count": 1, | ||
| "id": "thavma:greatwood_log" | ||
| }, | ||
| "pages": [], | ||
| "pageFeatures": [], | ||
| "position": [ | ||
| 0, | ||
| -3 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
src/main/java/me/alegian/thavma/impl/client/event/RegisterPageFeatureRenderersEvent.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package me.alegian.thavma.impl.client.event | ||
|
|
||
| import me.alegian.thavma.impl.client.gui.book.PAGE_FEATURE_RENDERERS | ||
| import me.alegian.thavma.impl.client.gui.book.PageFeatureRenderer | ||
| import me.alegian.thavma.impl.common.book.PageFeature | ||
| import me.alegian.thavma.impl.common.book.PageFeatureType | ||
| import net.neoforged.bus.api.Event | ||
| import net.neoforged.fml.event.IModBusEvent | ||
|
|
||
| class RegisterPageFeatureRenderersEvent : Event(), IModBusEvent { | ||
| fun <T : PageFeature> register(pageFeatureType: PageFeatureType<T>, pageFeatureRenderer: PageFeatureRenderer<T>) { | ||
| PAGE_FEATURE_RENDERERS[pageFeatureType] = pageFeatureRenderer | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like you deleted content here