Repository navigation
Complete icon turns green when activated. - #252
Merged
alanvardy merged 5 commits intoNov 13, 2026
Merged
Conversation
alanvardy
force-pushed
the
alanvardy-var-1178-complete-icon-turns-green-when-activated
branch
from
November 13, 2026 15:08
bf02e22 to
0fb279c
Compare
alanvardy
marked this pull request as ready for review
November 13, 2026 15:08
The complete toolbar icon stayed green for CreationFeedback.displayDuration (1.0s) while the green screen flash lasted CompletionGlow.duration (0.5s). Default CompletionFlash.duration to the glow's duration so the icon and the flash land on the same beat, and leave CreationFeedback.displayDuration at 1.0s so the dictation checkmark's hold is unchanged. Update Completion Flash tests to tie the default to CompletionGlow and guard the dictation duration.
alanvardy
force-pushed
the
alanvardy-var-1178-complete-icon-turns-green-when-activated
branch
from
November 13, 2026 15:08
0fb279c to
6172826
Compare
The complete toolbar item read `completionFlash.isActive` correctly, but its active state used a `Label` with `.foregroundStyle(.green)`. A toolbar `Button` supplies the tint, which overrides a nested `Label`'s foreground style, so the icon kept its idle tint — the green screen flash appeared but the icon never did. The dictate button's coloured states already dodge this by colouring a bare `Image`; match that. Stretch `completionFlash` in the `--ui-testing-glow` seam (alongside the glow) and add a UI test that probes the rendered pixels of the complete item while the flash is active — the only layer where the bug was observable. Verified red-first: the probe fails without this fix and passes with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.