Skip to content

Complete icon turns green when activated. - #252

Merged
alanvardy merged 5 commits into
mainfrom
alanvardy-var-1178-complete-icon-turns-green-when-activated
Nov 13, 2026
Merged

alanvardy merged 5 commits into
mainfrom
alanvardy-var-1178-complete-icon-turns-green-when-activated

Conversation

@alanvardy

Copy link
Copy Markdown
Owner

No description provided.

@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

VAR-1178

@alanvardy
alanvardy force-pushed the alanvardy-var-1178-complete-icon-turns-green-when-activated branch from bf02e22 to 0fb279c Compare November 13, 2026 15:08
@alanvardy
alanvardy marked this pull request as ready for review November 13, 2026 15:08
The complete toolbar icon stayed green for CreationFeedback.displayDuration
(1.0s) while the green screen flash lasted CompletionGlow.duration (0.5s).
Default CompletionFlash.duration to the glow's duration so the icon and the
flash land on the same beat, and leave CreationFeedback.displayDuration at
1.0s so the dictation checkmark's hold is unchanged.

Update Completion Flash tests to tie the default to CompletionGlow and guard
the dictation duration.
@alanvardy
alanvardy force-pushed the alanvardy-var-1178-complete-icon-turns-green-when-activated branch from 0fb279c to 6172826 Compare November 13, 2026 15:08
The complete toolbar item read `completionFlash.isActive` correctly, but its
active state used a `Label` with `.foregroundStyle(.green)`. A toolbar
`Button` supplies the tint, which overrides a nested `Label`'s foreground
style, so the icon kept its idle tint — the green screen flash appeared but
the icon never did. The dictate button's coloured states already dodge this
by colouring a bare `Image`; match that.

Stretch `completionFlash` in the `--ui-testing-glow` seam (alongside the glow)
and add a UI test that probes the rendered pixels of the complete item while
the flash is active — the only layer where the bug was observable.

Verified red-first: the probe fails without this fix and passes with it.
@alanvardy alanvardy added land Ready to land tested Manually verified and removed human labels Nov 13, 2026
@alanvardy
alanvardy merged commit 25913f5 into main Nov 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

land Ready to land tested Manually verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant