Repository navigation
Add screenshots for the iphone duo - #105
Merged
alanvardy merged 10 commits intoNov 13, 2026
Merged
Conversation
- Validate --duo-pose and an exported DUO_POSE in one place, exiting 2 before any simulator work; guard a bare --duo-pose against set -u. - Print a summary line when the iphone-duo class is skipped (no runtime). - Tighten the --display assertions to target the capture call, not preflight. - Cover the env-var and bare-flag validation with two shell tests.
alanvardy
force-pushed
the
alanvardy-var-1173-add-screenshots-for-the-iphone-duo
branch
from
November 13, 2026 22:00
4ab80c8 to
af13a47
Compare
alanvardy
marked this pull request as ready for review
November 13, 2026 22:00
A bare appstore-screenshots run captured iphone-6.3 only; the other classes had to be named explicitly. Default CLASSES to iphone-6.3, ipad-13, watch-46mm and iphone-duo, and name the expected size in the preflight temp file so the shell tests can exercise the all-class run. iphone-duo still captures the active Device Hub hinge pose; use --duo-pose book/open for the inner variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.