Skip to content

Add screenshots for the iphone duo - #105

Merged
alanvardy merged 10 commits into
mainfrom
alanvardy-var-1173-add-screenshots-for-the-iphone-duo
Nov 13, 2026
Merged

alanvardy merged 10 commits into
mainfrom
alanvardy-var-1173-add-screenshots-for-the-iphone-duo

Conversation

@alanvardy

Copy link
Copy Markdown
Owner

No description provided.

@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

VAR-1173

- Validate --duo-pose and an exported DUO_POSE in one place, exiting 2
  before any simulator work; guard a bare --duo-pose against set -u.
- Print a summary line when the iphone-duo class is skipped (no runtime).
- Tighten the --display assertions to target the capture call, not preflight.
- Cover the env-var and bare-flag validation with two shell tests.
@alanvardy
alanvardy force-pushed the alanvardy-var-1173-add-screenshots-for-the-iphone-duo branch from 4ab80c8 to af13a47 Compare November 13, 2026 22:00
@alanvardy
alanvardy marked this pull request as ready for review November 13, 2026 22:00
A bare appstore-screenshots run captured iphone-6.3 only; the other
classes had to be named explicitly. Default CLASSES to iphone-6.3,
ipad-13, watch-46mm and iphone-duo, and name the expected size in the
preflight temp file so the shell tests can exercise the all-class run.

iphone-duo still captures the active Device Hub hinge pose; use
--duo-pose book/open for the inner variants.
@alanvardy alanvardy added land tested Manually verified and removed human labels Nov 13, 2026
@alanvardy
alanvardy merged commit 2d4db74 into main Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

land tested Manually verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant