7128.43s.secret#39
Closed
alanking wants to merge 7 commits into
Closed
Conversation
Adds a test with istream which writes no bytes to the target replica to show that mtime updates when a replica is truncated, but it is not updated when the replica is not truncated.
The mtime will be updated whenever the replica is truncated, but it will not update whenever the replica is not truncated, regardless of the fact that the replica was not written to (just opened and closed). Uses replica_open and replica_close.
To follow POSIX more closely, this commit makes a replica's mtime update in the catalog along with its size and checksum at open time if it is opened for write and the truncate open flag was used (O_TRUNC).
Adds a test which calls rc_replica_close with update_status disabled and compute_checksum enabled. These options should be incompatible.
This commit prevents replica_close from completing if the user disabled update_status and enabled compute_checksum. The operation cannot complete because the target replica will be in the intermediate status when the checksum is supposed to be computed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.