fix(validate): restore lax whitespace validation for customer migration#340
Merged
jessesuen merged 1 commit intoApr 2, 2026
Merged
Conversation
Intentionally reverts the whitespace trimming introduced in upstream PR argoproj#11781 (commit 07c2560) to restore lenient input parameter validation from v3.4.6 behaviour. Templates using spaced references like '{{ inputs.parameters.foo }}' where 'foo' is not declared in inputs will now pass validation again, matching pre-v3.4.12 behaviour. Non-spaced references like '{{inputs.parameters.foo}}' are unaffected and retain strict validation. This is a scoped, intentional change for the akuity release-3.7.10 branch to allow Adobe customers to migrate their WorkflowTemplates without immediate failures. Not intended for upstream contribution. Refs: argoproj#11781, argoproj#11767
jessesuen
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Motivation
Templates using spaced variable references like
{{ inputs.parameters.foo }}wherefooisnot declared in the template's
inputs.parameterswere failing validation with:Upstream PR argoproj#11781 (commit
07c256085) introduced a correct bug fixthat added
strings.TrimSpace(tag)inresolveAllVariables. However, some existing users wereinadvertently relying on the pre-fix behaviour, causing validation failures after upgrading.
This is an intentional, scoped revert for the akuity
release-3.7.10branch to restore thelax v3.4.6 behaviour and ease user template migration. Not intended for upstream contribution.
Modifications
trimmedTag := strings.TrimSpace(tag)inresolveAllVariablesinworkflow/validate/validate.gotrimmedTagusages back totag{{inputs.parameters.foo}}are unaffected and retain strict validationVerification
TestUndeclaredSpacedParamPassesValidationwith a WorkflowTemplate referencing{{ inputs.parameters.chart-path }}(undeclared, with spaces). Confirmed it fails withtemplates.update-env: failed to resolve {{ inputs.parameters.chart-path }}on unmodified code.resolveAllVariables.TestShouldCheckValidationToSpacedParameters(added by PR fix: verify whitespaced parameters in workflow templates. Fixes #11767 argoproj/argo-workflows#11781) to reflect the restored lax behaviour.
./workflow/...test suite run — all 37 packages pass, zero failures.Documentation
No documentation changes needed — this is a scoped internal revert, not a new feature.