check: fix #969 gaps (E001 value position, script-created SET targets, CE8812, MPR006, quoted params)

[ako]

Closes #969

All five check gaps from the JTSBootLogboek redesign. I measured every mxbuild and runtime claim before encoding it.

Per item

1. E001 false positive. E001 and E002 used to run on every string literal in an enum or boolean slot. They now run only on literals in value position: the whole expression, a parenthesised one, or a then/else result (recursively) (mdl/exprcheck/parser.go, checkValueLiterals). A literal in a comparison, a function argument or an if-condition is no longer reported.

   • Side finding. When the enum and entity are created in the same script, check now catches a genuine change $X (EnumAttr = 'NW'). TypeCheckProgram overlays script-declared enumerations and attributes (create entity, alter entity add/modify attribute) onto the catalog reader (exprcatalog.DeclareEnumeration / DeclareAttribute).
   • Measured on 11.13.0. The if $Dir = 'NW' then E.NW else E.N and find('|NW|…', …) forms build with 0 errors. A quoted then 'NW' is CE0117, so it is still E001.

2. alter page … set Action = microflow M.X on btn with X created in the same script. The SET dry run now treats a typed NotFoundError for a microflow, nanoflow, page or snippet that the script declares as satisfied (validate_alter_set.go, scriptDeclaresMissing). I did not register fake IDs in ctx.Cache, because exec shares the executor. Microflow, nanoflow and show-page targets were all affected and are all fixed.

   • Measured on 11.13.0. exec'd and mx check gives 0 errors.

3. CE8812, new rule MDL-ASSOCDS01 (validate_assoc_list_source.go, hooked into the attribute-scope walk that already carries the data context). I measured 8 association shapes × list view, data grid and gallery on 11.13.0 and 11.14.0, with identical results:

   • CE8812 for a Reference followed from its FROM entity, with owner Default or Both.
   • CE8812 for a Reference with owner Both followed from its TO entity.
   • No error for the reverse of a default Reference, or for any ReferenceSet.

   The rule fires on exactly those 9 widgets and nothing else. It covers stored and script-declared associations. It skips specializations, self-associations and multi-hop paths.

4. MPR006. I ran run --local --db-type hsqldb on 11.13.0 (React client) and loaded the page in headless Chromium via Playwright. Both a bare and a styled (Style: 'height: 6px;') empty container render. The widgets after them are present, with 0 console errors, and mx check reports 0 errors. MPR006 is now info in the quality category, reworded to "empty — valid and it renders, but probably unintended". The create-page skill no longer tells authors to pad containers.

5. MDL-PARAMQUOTE01 info hint. It fires for a quoted ContentParams/CaptionParams value that is one string literal and either:

   • is a call of a known Mendix built-in, with ( directly after the name (not excluded), or
   • contains a $Var/Attr path, or is exactly $Var.

   It does not fire on 'Total (incl. VAT)', 'length (cm)', 'not(yet)', 'Price in $', 'Cost: $5', 'Sum(of parts)' or 'a' + 'b'. Runtime-verified: the quoted formatDateTime(...) renders as its literal text.

Test plan

• go test ./mdl/executor/ ./mdl/exprcheck/... ./mdl/exprcatalog/ ./mdl/linter/... ./cmd/mxcli/ all pass.
• make build, make lint, make check-conformance, make check-findings, make check-skill-mdl and make sync-skills all pass.
• New tests, each with controls:
  • exprcheck/value_position_test.go
  • TestTypeCheckProgramSeesScriptCreatedEnum and TestTypeCheckProgramEnumSlotOperandsAreNotValues
  • TestAlterSet_ActionTargetsCreatedInScript and its control …Missing
  • TestAssocListSource_* (all 8 shapes × 3 widgets, data view control, script-declared association plus a ReferenceSet control)
  • TestQuotedTemplateParam_Hint
  • updated MPR006 metadata test
• Revert checks (each removed fix makes its test fail with the reported symptom):
  • parser.go reverted → 6 failures in the value-position tests, including the 3× E001 on find.
  • declareScriptTypes disabled → "got [], want one E001".
  • scriptDeclaresMissing disabled → "microflow/nanoflow/page not found" for all three.
  • checkAssocListSource disabled → 10 failures.
  • looksLikeExpression stubbed → 4 positive-case failures.
  • old empty_container.go → category, severity and "crash" assertions fail.
• End to end: checked and exec'd the repro scripts on copies of the 11.13 (jts2/App) and 11.14 (jts2/TA) scratch apps, then ran docker check.

Follow-ups (not done)

• E001 on a whole-literal value (change $X (Wind = 'NW')) is an error, but exec's writer rewrites it to T969.WindEnum.NW and mxbuild reports 0 errors. That makes check stricter than the build. Downgrading it is a design decision.
• With --references, alter page … insert … dynamictext (ContentParams: ({1} = formatDateTime([%CurrentDateTime%], 'yyyy'))) outside a data container is refused ("bindings cannot be qualified"), although the expression has no attribute path. This looks like a false positive and is unrelated to check: E001 false positive on enum assignment with if/then/else; alter page set Action cannot see a script-created microflow; CE8812 not foreseen; MPR006 wording; quoted ContentParams hint #969.
• MPR006 was measured on the React client only. The classic client cannot be selected through MDL here.
• The MDL-ASSOCDS01 and MDL-PARAMQUOTE01 codes are new; other parallel PRs may also be adding codes.

🤖 Generated with Claude Code