fix(check,describe,lsp,lint): #962 — CE0109 on void call outputs, flow-wide duplicate warning, LSP void calls, MPR010 on native

[ako]

Closes #962. All four items.

Measurements (mxbuild 11.13.0, PedApp copy, exec --no-check then docker check, compared with the baseline error list)

Construct	mxbuild
void Java call $V1 = …, then log … + $V1	CE0109 Undefined variable 'V1'
void JS call $V3 = … (stored JS_RevokeUploadedFileFromMemory), then $V3 as a call argument	CE0109
control: non-void Java call $V2 = …, then log … + $V2	0 errors
void call $V4 = …, declare $V4 …, then a read	0 errors
microflow: non-void Java call $R in each if/else branch	CE0111
microflow: retrieve $T in each if/else branch	CE0111
microflow: non-void call $L inside a loop, and again after it	CE0111
form DataView directly on an Atlas_Core.NativePhone_Default page	0 errors
control: the same on an Atlas_Default page	0 errors (MPR010 is a design warning)
the MPR010 advice applied on the native page (layoutgrid → row → column → dataview)	CE6858 "Please update Atlas UI to version 2.4 or higher to use Layout Grid on Native pages"
form DataView in a snippet of Type Native (raw-patched from Web)	0 errors
layoutgrid-wrapped form in a native snippet	CE6858

1. check reports a read of a void call's output name (MDL093)

A new rule, checkVoidCallOutputUse, runs for microflows and nanoflows. It reports a name if three things hold: the only thing naming it is a call known to be void (from the script, or from the project with -p), nothing else in the flow defines it (a parameter, a declare, or a non-void producer, anywhere in the flow), and the flow reads it. It reports each name once, as an error that names CE0109.

The void resolver now returns voidness{void, known} instead of a bool. An unresolvable action is never reported as MDL093, whatever the duplicate-name policy says. Severity is error, so exec refuses it through the shared ValidateProgram.

Note: I picked rule ID MDL093 as the next free one. A parallel PR may pick the same ID.

2. describe's duplicate-output warning is flow-wide

duplicateOutputVariableWarnings now counts non-void output names over every object collection, loop bodies included, and warns for any name that is created twice. The reachability walk is gone, and #710's cost concern goes with it because the count is linear (the 120-diamond test still passes). Void calls are still excluded.

TestFormatMicroflowActivitiesDoesNotWarnForExclusiveBranchOutputs pinned the old scoping. It is now …WarnsForExclusiveBranchOutputs, and there is a new loop-body test. On the scratch app, describe now warns for the three CE0111 microflows above. Every Studio Pro-authored microflow and nanoflow in PedApp still describes without the warning.

3. The LSP resolves void action calls through the project

runSemanticValidation used executor.ValidateMicroflow/ValidateNanoflow, which pass a nil resolver. It now uses the new executor.FlowRules (NewFlowRules(prog, s.findMprPath(), s.codeActions)):

• Actions resolve through the script and the workspace project. The project is opened lazily, only when a call needs it.
• An action that neither can resolve is treated as possibly void. It is not an MDL063 duplicate, and it is never MDL093.
• One stored-action read costs about 320 ms on PedApp, so project answers are cached in the server for 30 s between keystrokes (CodeActionCache).

check keeps the strict reading from #958: an unresolvable call still counts as a declaration. The issue text says "as check does", but check does not treat unknown as void. I left check as it is, since #958 chose that deliberately to avoid hiding a real CE0111.

4. MPR010 on native pages

The advice does not apply, as the measurements above show.

• lint: skips pages in LintContext.NativePages() and snippets whose stored Type is Native. The rule now declares RequiredCatalogMode() = CatalogFull, because LayoutRef is only recorded by a full build. A default lint already builds full because of MPR012. NativePages is added to the catalog-mode guard list, so a future rule that reads it without declaring full fails the test.
• check: ValidatePageLayoutGrid(prog, nativeLayout). With -p, it asks the project (layoutIsNative) whether a page's layout is native, and only for a page that has something to report. Without a project it warns as before.

Test plan

• New tests:
  • mdl/executor/validate_void_call_output_test.go: MDL093 table with controls (non-void, declare, parameter, unresolvable, unread), plus possibly-void vs known-void
  • cmd/mxcli/check_void_calls_test.go TestCheck_ReadOfAStoredVoidCallOutput: PedApp stored void JS action, Boolean and unresolvable controls
  • cmd_microflows_duplicate_output_test.go: branches and loop body
  • cmd/mxcli/lsp_void_calls_test.go: PedApp, with and without a project, Boolean control, MDL093 only with the project
  • TestCodeActionCache_SharesProjectAnswersAcrossRuns
  • mdl/linter/rules/dataview_layout_grid_test.go TestDataViewLayoutGridRule_SkipsNativePagesAndSnippets: real catalog plus a raw-unit reader, with web page and web snippet controls
  • validate_page_layout_test.go TestValidatePageLayoutGrid_SkipsNativeLayouts
  • cmd/mxcli/check_native_layout_grid_test.go: PedApp check -p
• Revert checks (fix removed → the test fails with the symptom → fix restored):
  • MDL093 wiring for microflows and nanoflows (unit and cmd)
  • old duplicateOutputVariableWarnings (both describe tests fail)
  • LSP back on ValidateMicroflow/ValidateNanoflow (3 assertions fail)
  • unknownIsVoid line (no-project assertion fails)
  • shared-cache lookup (re-open assertion fails)
  • MPR010 native-page skip, native-snippet skip, and RequiredCatalogMode (each fails its test, the last via the catalog-mode guard)
  • check-side projectNativeLayouts → nil (cmd test fails)
• End to end on the scratch app: check -p reports MDL093 for the CE0109 flows only. lint --rules MPR010 reports only the web page, and also the snippet once it is flipped back to Web.
• make build, go test ./mdl/executor/ ./mdl/linter/... ./cmd/mxcli/, make check-conformance, make lint, make check-findings, make check-skill-mdl, make sync-skills

Findings appended to mdl-executor.jsonl (items 1 and 2), cmd-mxcli.jsonl (item 3) and mdl-other.jsonl (item 4). CHANGELOG has entries under Unreleased / Fixed.

Not done

• The bug-pattern digest (check-mxbuild-drift.md) is not re-synced.

🤖 Generated with Claude Code