fix(audit-2): address adversarial audit findings#2
Open
ajayita wants to merge 1 commit into
Open
Conversation
- GMCP Parser: strip null bytes globally, return null on malformed UTF-8 or invalid JSON - Transport Cleanup: always await transport.close() in finally; close decompressor sink properly - AuditResult: add latency and capped (4KB) rawBytesExchanged; serialize bytes as base64 in JSON - NegotiationStateManager: add global+per-option rate limiting with Stopwatch, throw TelnetProtocolException on loop detection - Entry Point: create lib/telnet_sentinel.dart with clean public API and lib/telnet_auditor.dart - pubspec.yaml: add homepage, repository, issue_tracker, and topics metadata - Update tests to assert new strict GMCP behavior and add tests for rate limiting, raw byte capping, and null-byte stripping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the issues discovered in
audit-2.md.Fixes Applied
nullon malformed UTF-8 or invalid JSON instead of swallowing errors.await transport.close()in afinallyblock. Close_decompressorSinkinTelnetTransport.close().lib/telnet_sentinel.dartwith a clean public API surface. Addhomepage,repository,issue_tracker, andtopicstopubspec.yaml. IntroduceTelnetAuditorfacade._rawBytesExchangedat 4KB. Serialize captured bytes as base64 intoJson(). Add per-probelatencytracking.Stopwatch. ThrowTelnetProtocolExceptionon loop detection instead of silently dropping.Test Updates
nullfor invalid JSON.Verification
dart analyze— cleandart test— all 71 tests pass