docs: never catch blanket exceptions in workflow code - #33
Merged
Merged
Conversation
rgamba
marked this pull request as ready for review
September 18, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds guidance to the docs site that workflow code must not catch
Throwable,Exception,RuntimeException, orError. Skipper drives execution through exceptions:waitUntilsuspends a workflow by throwing an internal control-flow signal, and action failures surface as retryable or non-retryable errors that the engine needs to see. A blanketcatchintercepts both and sends the workflow down a path it was never meant to take.Where it lives
runCatching.Exceptiontoo and links to the new section.waitUntildocs, linking to the new section.The full explanation lives in one place and the other pages link to it, so the rule is discoverable from wherever a reader is likely to hit the problem without repeating the rationale three times.
Testing
npx astro buildinweb/passes, 32 pages built.dont-catch-blanket-exceptions-in-workflow-codeexists in the built Error Handling page and that both cross-links in the built Core Concepts and Workflow API pages point at it.waitUntil(condition)overload defined inWorkflow.kt.