web: make the docs site usable on phones - #32
Merged
Merged
Conversation
added 2 commits
September 18, 2026 11:51
The site overflowed horizontally at phone widths and hid all primary navigation below 860px with no replacement. - Hero and code-layout grid columns get min-width: 0 so a code block's longest line no longer sizes the column past the viewport (the homepage was 480px wide on a 375px screen). - Inline code in prose wraps (overflow-wrap: anywhere) instead of widening the page; the Quickstart's Maven coordinate forced a 434px layout viewport. - Nav collapses the Docs/Examples/Community links behind a hamburger with a dropdown panel; the hero nav turns white while the menu is open so the panel reads as one surface. The GitHub button shrinks to an icon under 520px. - Docs sidebar collapses its ~25 links behind a "Browse the docs" toggle on narrow screens so the article is not pushed below the fold; search stays visible. Pager links stack. - Phone-width spacing pass: 16px gutters, tighter section padding, smaller hero type, full-width flow steps, footer brand spanning both columns, and a body-level overflow-x: clip as a safety net.
.hero__inner set the padding shorthand with 0 on the sides, overriding the container's 24px gutters at every breakpoint. Use 24px (16px on phones) so the hero content aligns with the header and the rest of the page.
rgamba
marked this pull request as ready for review
September 18, 2026 19:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs site at skipper.airbnb.tech was broken on phones: the homepage rendered 480px wide on a 375px screen, the Quickstart forced a 434px layout viewport, and every primary nav link disappeared below 860px with nothing in its place. This PR fixes the overflow at its causes and adds the two mobile affordances the site was missing.
What changed
Overflow root causes, not symptoms. Two things were widening the page:
LangTabscode block dictate the column width. Grid items default tomin-width: auto, so the longest unbroken line of Kotlin became the column's minimum. Both grids now give their childrenmin-width: 0, and the<pre>scrolls internally as intended.<code>in prose (Maven coordinates, class names) had no break opportunities. It now usesoverflow-wrap: anywhere. Table cells keepnowrapbecause the table already scrolls.A
body { overflow-x: clip }safety net is added as well.cliprather thanhiddenso body does not become a scroll container and sticky positioning keeps working.Mobile nav. Below 860px the Docs / Examples / Community links collapse behind a hamburger that opens a full-width dropdown panel under the header, with "Get Started" added since the ghost button is hidden there. On the homepage's blue hero nav, opening the menu also applies the white "scrolled" style so the panel and header read as one surface. Closes on link click, Escape, outside click, or crossing back to the desktop breakpoint. Under 520px the GitHub button drops to an icon.
Docs sidebar. On narrow screens the sidebar sits above the article, and its ~25 links pushed the content well below the fold. The nav list now collapses behind a "Browse the docs" toggle; search stays visible. Prev/next pager links stack vertically.
Spacing pass at ≤600px. 16px gutters, tighter section and hero padding, smaller hero heading, full-width "how it works" steps, footer brand spanning both columns, and the scroll-padding offset reduced to match the shorter header.
Trade-offs
Testing
Verified in a 375×812 mobile-emulated browser against the dev server, before and after:
//docs/quickstart//docs/reference/configuration/(tables)/examples/,/community/,/docs/Also exercised: hamburger open/close (button, Escape), docs "Browse the docs" toggle, footer at phone width, and a 1280px desktop check of the homepage and Quickstart to confirm no regression.
npm run buildcompletes with all 32 pages.