Skip to content

Fix invalidation after horizontal insets change#164

Merged
bryankeller merged 1 commit into
masterfrom
bk/fix-invalidation-after-insets-change
Jun 25, 2026
Merged

Fix invalidation after horizontal insets change#164
bryankeller merged 1 commit into
masterfrom
bk/fix-invalidation-after-insets-change

Conversation

@bryankeller

Copy link
Copy Markdown
Contributor

Details

When the new experimental optimizations are enabled, we default to invalidating less often. This revealed a case that should have been handled before - if the width or the horizontal insets change, we must invalidate layout metrics the next time prepare runs. Previously, we were only invalidating if the width changed.

This would be a good candidate for a unit test once I add tests for the layout object.

How Has This Been Tested

Airbnb app.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller requested a review from brynbodayle June 25, 2026 18:56
@bryankeller bryankeller force-pushed the bk/fix-invalidation-after-insets-change branch from a969158 to 639af0d Compare June 25, 2026 18:57
@bryankeller bryankeller merged commit 0e98b7a into master Jun 25, 2026
1 check passed
@bryankeller bryankeller deleted the bk/fix-invalidation-after-insets-change branch June 25, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants