Fix invalidation after horizontal insets change#164
Merged
Conversation
a969158 to
639af0d
Compare
brynbodayle
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When the new experimental optimizations are enabled, we default to invalidating less often. This revealed a case that should have been handled before - if the width or the horizontal insets change, we must invalidate layout metrics the next time prepare runs. Previously, we were only invalidating if the width changed.
This would be a good candidate for a unit test once I add tests for the layout object.
How Has This Been Tested
Airbnb app.
Types of changes
Checklist