Provide more information in error log by logging request body for val…#724
Open
KushanSingh-Kalvium wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Change Type: Changed
Change Category: Internal
Changelog Entry:
Improve error logging for asset uploads by including the request body
in the logged error information.
Previously, the error log displayed ""
because the request body stream had already been consumed when the
exception handler executed.
This change introduces a helper function that safely retrieves the
request body and includes it in the log output. The logging behavior
has also been extended to handle both
HTTPExceptionandRequestValidationError, ensuring that request data is available inlogs for debugging upload failures.
How to Test
Run the test suite:
pytest src/tests/test_error_response.pyVerify that:
"".
Checklist
Related Issues
Closes #485