Allow precomputed net surface flux forcing in ocean's hfds prescribing#1229
Open
jpdunc23 wants to merge 2 commits into
Open
Allow precomputed net surface flux forcing in ocean's hfds prescribing#1229jpdunc23 wants to merge 2 commits into
hfds prescribing#1229jpdunc23 wants to merge 2 commits into
Conversation
_compute_ocean_net_surface_energy_flux now takes the atmosphere net surface energy flux (base_flux) from a precomputed net_surface_energy_flux forcing field when present, falling back to computing it from the constituent fluxes otherwise. The two are equivalent by construction, but the precomputed path is needed when the constituents are dropped from the forcing and only the derived net flux is fed to the network. The SST-dependent mass heat flux term is still computed from the constituent precipitation and latent heat fluxes, which must remain available in forcing_data. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jpdunc23
changed the title
hfds prescribinghfds prescribing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_compute_ocean_net_surface_energy_fluxnow defaults to taking the atmosphere net surface energy flux (base_flux) from a precomputed"net_surface_energy_flux"forcing field when present, falling back to computing it from the constituent fluxes otherwise. The two are equivalent by construction, but the former allows for dropping many of the individual surface flux terms from the set of input forcings to the network.The SST-dependent mass heat flux term is still computed from the constituent precipitation and latent heat fluxes, which must remain available in
forcing_data.Changes:
symbol (e.g.
fme.core.my_function) or script and concise description of changes or added featureCan group multiple related symbols on a single bullet
Tests added
If dependencies changed, "deps only" image rebuilt and "latest_deps_only_image.txt" file updated
Resolves # (delete if none)