Skip to content

Update project / maintenance#29

Open
nbdy wants to merge 8 commits into
ai-forever:mainfrom
nbdy:main
Open

Update project / maintenance#29
nbdy wants to merge 8 commits into
ai-forever:mainfrom
nbdy:main

Conversation

@nbdy

@nbdy nbdy commented Apr 15, 2024

Copy link
Copy Markdown
  • Replaced setup.py with pyproject.toml
  • Updated requirements.txt (opencv was not used)
  • Renamed module from RealESRGAN (collides with original pypi project) to py-real-esrgan
  • Moved main.py to real_esrgan/main.py and added arguments (scale, model path, input path, output path)
  • Updated README.md
  • Reformatted code / optimized imports

@jag-k jag-k left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really need to rename a project?

Comment thread pyproject.toml
]
dependencies = [
"numpy",
"opencv-python",

@jag-k jag-k Sep 2, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need it?

I think you forgot to delete :)

Suggested change
"opencv-python",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it is not imported anywhere. I missed that.

Comment thread requirements.txt
Comment on lines 1 to 4
numpy
opencv-python
Pillow
torch>=1.7
torchvision>=0.8.0

@jag-k jag-k Sep 2, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think we can delete this file entirely 'cause we already use pyproject.toml for it

Suggested change
numpy
opencv-python
Pillow
torch>=1.7
torchvision>=0.8.0

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I kept this file is that PyCharm prompts the user if there are any missing dependencies.
It was more a convenience for me. Generally we can remove it, yes.

@nbdy

nbdy commented Sep 3, 2024

Copy link
Copy Markdown
Author

If you don't intent to publish it to pypi or if you don't want anyone to publish their work using this library on pypi there is no need to rename the project.
pypi.org does not allow a direct link as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants