Update project / maintenance#29
Conversation
add arguments
optimize imports
jag-k
left a comment
There was a problem hiding this comment.
Are we really need to rename a project?
| ] | ||
| dependencies = [ | ||
| "numpy", | ||
| "opencv-python", |
There was a problem hiding this comment.
Why we need it?
I think you forgot to delete :)
| "opencv-python", |
There was a problem hiding this comment.
You are right, it is not imported anywhere. I missed that.
| numpy | ||
| opencv-python | ||
| Pillow | ||
| torch>=1.7 | ||
| torchvision>=0.8.0 |
There was a problem hiding this comment.
And I think we can delete this file entirely 'cause we already use pyproject.toml for it
| numpy | |
| opencv-python | |
| Pillow | |
| torch>=1.7 | |
| torchvision>=0.8.0 |
There was a problem hiding this comment.
The reason I kept this file is that PyCharm prompts the user if there are any missing dependencies.
It was more a convenience for me. Generally we can remove it, yes.
|
If you don't intent to publish it to pypi or if you don't want anyone to publish their work using this library on pypi there is no need to rename the project. |
Uh oh!
There was an error while loading. Please reload this page.