Repository navigation
Reject query parameter values with invalid encoding or are too long - #505
Merged
Merged
Conversation
- Query and cookie parameter values with invalid encoding (like `?search=%C3`) produce a 400 response now. Before such a value passed validation or raised an `ArgumentError`. This applies to documented and undocumented query parameter, but only to documented cookie parameters. - Fix: A query string with more parameters than Rack accepts (4096 by default) produces a 400 response now instead of raising `Rack::QueryParser::QueryLimitError`.
ahx
force-pushed
the
reject-invalid-encoded-query-parameters
branch
2 times, most recently
from
October 1, 2026 15:12
90a8b79 to
97657ac
Compare
- Query and cookie parameter values with invalid encoding (like `?search=%C3`) produce a 400 response now. Before such a value passed validation or raised an `ArgumentError`. This applies to documented and undocumented query parameter, but only to documented cookie parameters. - A query string with more parameters than Rack accepts (4096 by default) produces a 400 response now instead of raising `Rack::QueryParser::QueryLimitError`.
ahx
force-pushed
the
reject-invalid-encoded-query-parameters
branch
from
October 1, 2026 15:14
97657ac to
eb05036
Compare
ahx
marked this pull request as ready for review
October 1, 2026 15:16
Owner
Author
|
Any thoughts on this? 📡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?search=%C3) produce a 400 response now. Before such a value passed validation or raised anArgumentError. This applies to documented and undocumented query parameter, but only to documented cookie parameters.Rack::QueryParser::QueryLimitError.Bump version to 4.1.0