Move session's interface method Unlock, Done and Err into interface Service#10
Merged
Conversation
…ervice A service is actually just a lock returned by NewLock. If users call the Lock or TryLock again without Unlock beforehand, then it should just return the same Grant with the same Fencing token. The Done channel is only created when the NewLock is called, it doesn't change at all each time when Lock or TryLock is called Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
There was a problem hiding this comment.
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A service is actually just a lock returned by NewLock. If users call the Lock or TryLock again without Unlock beforehand, then it should just return the same Grant with the same Fencing token.
The Done channel is only created when the NewLock is called, it doesn't change at all each time when Lock or TryLock is called.
So it doesn't make much sense to have a session object.