Repository navigation
Keep WooCommerce's setup wizard out of admin request tests - #31
Merged
Merged
Conversation
CI's Integration lane failed one OptionsPage row on the PR and another on trunk, while every local run passed. WooCommerce keeps a 30-second _wc_activation_redirect transient after a fresh install and sends the next admin request of a store manager to its setup wizard. CI activates WooCommerce right before the suite, so that request's tab printed no form, and the save posted after it changed nothing. The request runner now filters woocommerce_prevent_automatic_wizard_redirect to true, which makes WooCommerce delete the transient instead of redirecting, and the tests' form serializer fails when the page printed no settings form. Setting the transient by hand reproduced the trunk failure before the change, and the OptionsPage rows pass with it set after. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's Integration lane failed one OptionsPage row on the PR and another on trunk, while every local run passed. WooCommerce keeps a 30-second
_wc_activation_redirecttransient after a fresh install and sends the next admin request of a store manager to its setup wizard. CI activates WooCommerce right before the suite, so that request's tab printed no form, and the save posted after it changed nothing.The request runner now filters
woocommerce_prevent_automatic_wizard_redirectto true, which makes WooCommerce delete the transient instead of redirecting, and the tests' form serializer fails when the page printed no settings form. Setting the transient by hand reproduced the trunk failure before the change, and the OptionsPage rows pass with it set after.Affected packages
wp-framework-bootstrapwp-framework-sharedwp-framework-corewp-framework-settingswp-framework-woocommerceChecklist
tests/Integration/Support/admin-request.phpandOptionsPageTest::form_data(); no package code changes.composer quality-checkpasses locally (Unit 200, Integration 685), pluscomposer test:integration:multisite(26) and PHP 7.4php -loverpackages/bootstrapREADME.md(no public API change)