fix: avoid reusing request seeds across GRPO repeats - #628
Merged
pan-x-c merged 2 commits intoSep 29, 2026
Merged
Conversation
Collaborator
Author
|
/unittest-module-common |
Collaborator
Author
|
/unittest-module-explorer |
unittest: Run #1879
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-pattern-RolloutSeedTest or test_workflow_runner_partial_success_non_repeatable or test_workflow_runner_fail_fast_without_partial_collection |
unittest: Run #1885
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
pan-x-c
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tinker inference currently falls back to the same configured seed for every sampling request. Repeated rollouts that start with the same prompt can therefore replay the same trajectory, removing the within-group reward variation that GRPO needs.
Leave the Tinker request seed unset unless the caller explicitly supplies one. Expose the task's repeat index to non-repeatable workflows before execution, including the offset when a group is split across runners, and use that index to give step-wise ALFWorld repeats distinct reproducible request seeds. Explicit seeds, including zero, remain supported.
This change is independent of training-loss or TuFT server changes.
Validation
git diff --checkpassed for the changed files.vllm.inputs.MultiModalDataDicttype alias imported by current main; the test process supplied that type-only alias before collecting tests. No repository code or inference implementation was replaced for this workaround.Checklist