Repository navigation
examples/minimal README: placeholder root key, and "advisory" contradicts the config #218
Description
Checked at 8113abd.
Two things in examples/minimal/README.md:
- Line 14 tells readers to run
--trusted-root-issuer <trusted-root-issuer-hex>, but the real key is already pinned inca2a-config.yaml(eda38c44...eb162). With that key,ca2a verify-chain --chain chain.json --trusted-root-issuer <key>returns{"verified": true, "hops": 3, "leaf_scope": ["cap:read"], ...}. - Line 7 calls the config "software-only, advisory". The file sets
enforcement_mode: enforcing, andca2a validate-configprintsok: provider=software-only enforcement=enforcing.
There is also no test for examples/minimal, while the other examples each have one.
Done when
- the README uses the real key and says "enforcing"
- a new
tests/unit/test_example_minimal.pyruns both commands throughca2a_runtime.cli.mainand assertsverified: trueand the configokline
Files: examples/minimal/README.md, one new test file.
Activity
aipd506 commentedon Sep 30, 2026
Hi @agentrust-io maintainers! 👋
I would like to resolve this issue and be vouched per
CONTRIBUTING.md.Summary of the fix I have prepared:
examples/minimal/README.md:<trusted-root-issuer-hex>placeholder with the actual pinned key (eda38c446da3db3eba68852ca9869260c36badd48b2cab16ec8d8faf607eb162) defined inca2a-config.yaml.ca2a-config.yamlfrom(software-only, advisory)to(software-only, enforcing)to match the config.tests/unit/test_example_minimal.py):ca2a verify-chainoffline againstexamples/minimal/chain.jsonwith the pinned key and assertsverified: True,hops: 3, andleaf_scope: ["cap:read"].ca2a validate-configagainstexamples/minimal/ca2a-config.yamland asserts exit code 0 andok: provider=software-only enforcement=enforcing.Could you please add me with
/vouchso my pull request can proceed with review? Thank you!imran-siddique commentedon Sep 30, 2026
/vouch @aipd506
github-actions commentedon Sep 30, 2026
@aipd506 is vouched by @imran-siddique. Pull requests from that account will not be closed by the vouch check.
chore: vouch aipd506
aipd506 commentedon Oct 1, 2026
Thank you @imran-siddique for the vouch. Pull request #220 is open and ready for your review whenever convenient.