api: open the sandboxClass enum for out-of-tree ateom-* backends#332
Open
Davanum Srinivas (dims) wants to merge 1 commit into
Open
api: open the sandboxClass enum for out-of-tree ateom-* backends#332Davanum Srinivas (dims) wants to merge 1 commit into
Davanum Srinivas (dims) wants to merge 1 commit into
Conversation
…h B / B2) Replace the closed +kubebuilder:validation:Enum=gvisor;microvm on SandboxConfig/WorkerPool/ActorTemplate .spec.sandboxClass with a DNS-label Pattern + MaxLength=63. gvisor/microvm stay the built-in defaults, but a custom ateom-* backend can now define its own sandboxClass and ship a matching SandboxConfig + WorkerPool without forking substrate (admission no longer rejects the class). Regenerate CRDs; update the ActorTemplate validation test (custom class "firecracker" accepted; pattern-violating "Bad_Class" rejected).
Davanum Srinivas (dims)
changed the title
Davanum Srinivas (dims)
changed the title
Collaborator
|
Intentionally didn't do this while they won't work / aren't supported ... cc Tim Hockin (@thockin) |
Collaborator
Author
|
Benjamin Elder (@BenTheElder) i have a branch where i copied ateom-microvm, renamed everything to ateom-foobar and got it working, so we can't say "they won't work" ... we can definitely say "aren't supported" until we have tests :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the closed
+kubebuilder:validation:Enum=gvisor;microvmonSandboxConfig/WorkerPool/ActorTemplate.spec.sandboxClasswith a DNS-labelPattern+MaxLength=63.gvisor/microvmstay the built-in defaults, but a customateom-*backend can now define its ownsandboxClass(and ship a matchingSandboxConfig+WorkerPool) without forking substrate — admission no longer rejects the class. Regenerate CRDs; update the ActorTemplate validation test (customfoobaraccepted, pattern-violatingBad_Classrejected).