lint: enable more golangci-lint plugins#144
Open
Arnaud M. (ameukam) wants to merge 3 commits into
Open
Conversation
Contributor
Author
Collaborator
|
This looks overall good, but: |
Collaborator
|
Let's hold on the formatters part. |
Reconciliation and RPC calls should inherit the caller's context instead of spinning up a detached context.Background(). Demo binaries are excluded from the linter. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Opt in to gocritic's high-signal bug-pattern checks only (disable-all plus an explicit enabled-checks allowlist). Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Enum switches now cover every case so a new value trips the linter instead of slipping past a default. Map checking stays opt-in (explicit-exhaustive-map); our only enum-keyed maps are partial corev1.ResourceList literals. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Arnaud M. (ameukam)
force-pushed
the
add-more-golangci-lint-linters
branch
from
86264f9 to
19b684c
Compare
Contributor
Author
Tim Hockin (@thockin) it's done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable contextcheck, gocritic, and exhaustive to catch detached contexts, bug patterns, and incomplete controller state-machine switches.
Assisted by GPT 5.5