docs: mark reviewer contract for cross-repo sync#28
Merged
Conversation
Adds REVIEWER-CONTRACT-VERSION markers in a JS comment block above the baseReviewPrompt template literal in audit-project-agents.md. The same contract also lives in prepare-delivery/skills/ orchestrate-review/SKILL.md and the two must stay semantically in sync (byte-identical is not possible - this copy escapes backticks inside a template literal). Comments live outside the template literal so they do not pollute the actual reviewer prompt text sent to subagents. No CI enforcement yet - documents the drift risk in CLAUDE.md and AGENTS.md as a known follow-up. Matching PR in prepare-delivery.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REVIEWER-CONTRACT-VERSION: 1marker as a JS comment block above thebaseReviewPrompttemplate literal incommands/audit-project-agents.mdprepare-delivery/skills/orchestrate-review/SKILL.mdmust stay in syncWhy
The false-positive contract is duplicated in two repos today (audit-project and prepare-delivery). They currently agree in intent but the text is not byte-identical - this copy escapes backticks inside a JS template literal. Rather than move to a shared file (cross-repo dependencies are awkward for plugins) we mark the block and rely on the sync rule in CLAUDE.md/AGENTS.md until CI catches up.
The marker comments live OUTSIDE the template literal so they do not pollute the actual reviewer prompt text sent to subagents.
Matching PR: agent-sh/prepare-delivery#3
Test plan
Note
Low Risk
Low risk documentation/comment-only change that does not alter runtime behavior, but helps prevent future drift in reviewer prompt semantics across repos.
Overview
Adds an explicit
REVIEWER-CONTRACT-VERSION: 1marker and start/end comment guards around the false-positive contract section ofbaseReviewPromptincommands/audit-project-agents.md, documenting that this block must stay semantically synced withprepare-delivery/skills/orchestrate-review/SKILL.md.Updates
AGENTS.mdandCLAUDE.mdcritical rules to require keeping the duplicated REVIEWER CONTRACT text aligned across both locations, noting the current lack of CI enforcement.Reviewed by Cursor Bugbot for commit 7c204cb. Configure here.