refactor(commands): remove duplicated content in skill-create and learn-eval#2348
refactor(commands): remove duplicated content in skill-create and learn-eval#2348pythonstrup wants to merge 1 commit into
Conversation
…rn-eval skill-create: drop the "Example Output" section (53 lines) — it re-rendered the same skeleton already defined by the Step 3 output template, just with filled-in `my-app` values. learn-eval: drop the "Next Action" column from the 5b verdict table — it duplicated Step 6's "Verdict-specific confirmation flow". The table now carries Verdict + Meaning, and a pointer to Step 6 as the single source for each verdict's action. No behavior, frontmatter, or design-rationale changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (28)
🧰 Additional context used📓 Path-based instructions (3)commands/**/*.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
{agents,skills,commands}/**/*.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
{skills,commands,agents,rules}/**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughTwo documentation files are trimmed. ChangesDocs Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
What Changed
Removed duplicated content from two workflow-extraction command docs:
commands/skill-create.md— dropped the## Example Outputsection (53 lines). TheStep 3: Generate SKILL.mdtemplate already defines the output structure (name/descriptionfrontmatter, Commit Conventions, Code Architecture, Workflows, Testing Patterns); the Example Output just re-rendered the same skeleton with filled-inmy-appvalues.commands/learn-eval.md— dropped theNext Actioncolumn from the 5b verdict table. It duplicated Step 6's "Verdict-specific confirmation flow". The table now carriesVerdict | Meaning, and the intro points to Step 6 as the single source for each verdict's action.Net: −53 lines, no information lost (each removed piece is still defined exactly once elsewhere in the same file).
Why This Change
Both files state the same thing twice, which invites drift — editing the template or Step 6 without updating its duplicate. Removing the redundant copy keeps a single source of truth and aligns with CONTRIBUTING's "focused, modular" guidance. Pure cleanup; no behavior or design changes.
Testing Done
node scripts/ci/validate-commands.js— 92 command files validated, exit 0npm run command-registry:check— registry up to date (no frontmatter changes)npx markdownlint commands/learn-eval.md commands/skill-create.md— cleanType of Change
refactor:Code refactoring (documentation dedup)Notes
Intentionally left taste-level content untouched (e.g. learn-eval's "Design Rationale" decision record). No frontmatter, behavior, or runtime changes.