Add missing physics collision classes and more#1820
Open
redstrate wants to merge 4 commits into
Open
Conversation
redstrate
force-pushed
the
work/redstrate/collision-n-shit
branch
from
884f3e2 to
188ad70
Compare
There was a bunch of (potentially useful) physics classes that haven't been created yet, which contain data about collisions and constraints. I didn't map out their fields and vfuncs yet, but the inheritance structure as detailed in classinformer is now set up. Collision objects are kept in BonePhysicsModule, and constraint objects are kept in BoneSimulator.
More documentation is added for the existing job data, and then I mapped out the one used for updating collision objects now that we have those. There's also a function used to allocate and create the job data in BonePhysicsModule which is useful to know about.
This is used to load the PHYB resource file and was helpful in figuring out how collision data was structured.
redstrate
force-pushed
the
work/redstrate/collision-n-shit
branch
from
188ad70 to
a37b3de
Compare
The fields were found in the Load function and correspond to how VFXEditor claims they are used (hence why the naming is taken from there.) The functions are for making the disassembly automatically more readable.
redstrate
force-pushed
the
work/redstrate/collision-n-shit
branch
from
a37b3de to
c35dbbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a heaping pile of physics classes we were missing, and a bunch of other stuff to make reading this code not a giant pain. See individual commits for reasoning/details.