Repository navigation
Ambient connection + bind/rows chain terminals - #18
Merged
Merged
Conversation
fquery/env.py: ContextVar ambient DBAPI connection with use()/current()/connection() scope. Query.bind(**kw) stores param bindings on the chain (inherited by wrapping ops). Query.rows(extra=None) runs on the ambient connection. to_rows(conn, params) stays as the explicit form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's call sites read as pure chains instead of threading sessions through execution:
fquery/env.py: ContextVar ambient DBAPI connection —use(conn)/current()/connection()scope manager. Thread- and async-safe; set once per request/test.Query.bind(**kw): stores param() bindings on the chain (wrapping ops inherit them via base init; same mutate-and-return convention as as_dict).Query.rows(extra=None): terminal that runs on the ambient connection. Explicitto_rows(conn, params)unchanged.Tests cover bind+rows over sqlite3, missing-connection error, and param quoting.