Skip to content

Ttomar/upload artifact#6452

Draft
TarunAdobe wants to merge 6 commits into
mainfrom
ttomar/upload-artifact
Draft

Ttomar/upload artifact#6452
TarunAdobe wants to merge 6 commits into
mainfrom
ttomar/upload-artifact

Conversation

@TarunAdobe

Copy link
Copy Markdown
Contributor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

TarunAdobe and others added 4 commits June 23, 2026 17:44
…bnails

Media artifacts no longer reserve space for an empty actions row, and
thumbnail content is positioned to cover the full tile. Storybook demos
now use stable picsum image previews instead of broken gradient placeholders.

Co-authored-by: Cursor <cursoragent@cursor.com>
Support mixed file types with a bottom-left overlay on type="media"
without introducing a new artifact type.

Co-authored-by: Cursor <cursoragent@cursor.com>
…trips

Match dismiss, radii, shadow, and badge spacing to design specs. Update
docs and stories for card-only or media-only attachment strips, warn in
prompt-field when types are mixed, and use media tiles with badges in the
pattern overview demo.

Co-authored-by: Cursor <cursoragent@cursor.com>
Add flanking chevron navigation and hidden-scrollbar trackpad scroll when
multiple attachments overflow the composer. Refine media dismiss sizing for
Figma alignment.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 67026a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6452

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

TarunAdobe and others added 2 commits June 26, 2026 11:53
Mount mixed artifacts after the console.warn spy is installed, and read badge
labels from the light DOM slot instead of shadow overlay textContent.

Co-authored-by: Cursor <cursoragent@cursor.com>
Document required legal disclaimers with a dev warning when missing.
Clarify that mixed uploads should normalize to media tiles with badges,
not card and media layouts in the same strip.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant