Skip to content

feat(actiongroup): migrate action group#6444

Draft
rise-erpelding wants to merge 1 commit into
mainfrom
swc-2212/migrate-action-group
Draft

feat(actiongroup): migrate action group#6444
rise-erpelding wants to merge 1 commit into
mainfrom
swc-2212/migrate-action-group

Conversation

@rise-erpelding

@rise-erpelding rise-erpelding commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Migrates the action group component to gen 2.

Motivation and context

Related issue(s)

  • Addresses epic SWC-2212

Child issues (check off as they're merged)

Related bugs resolved by Gen2 (check off as addressed)

  • SWC-621 Action Group: "disabled" attribute should be used to disable all action-button children
  • SWC-1342 sp-action-group sets z-index on focused button [Bug]: sp-action-group sets z-index on focused button #5815
  • SWC-889 sp-action-group change event fires before selection change
  • SWC-1121 Group of radio buttons not associated with group label - sp-action-group

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

@rise-erpelding rise-erpelding self-assigned this Jun 23, 2026
@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 49fb3e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rise-erpelding rise-erpelding added Status:WIP PR is a work in progress or draft Component:Action group 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. labels Jun 23, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28042511097

Warning

No base build found for commit 53f5752 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.244%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 39173
Covered Lines: 37902
Line Coverage: 96.76%
Relevant Branches: 6460
Covered Branches: 6017
Branch Coverage: 93.14%
Branches in Coverage %: Yes
Coverage Strength: 458.74 hits per line

💛 - Coveralls

@rise-erpelding rise-erpelding force-pushed the swc-2212/migrate-action-group branch from f169a5d to da08b85 Compare June 23, 2026 21:56
@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6444

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rise-erpelding rise-erpelding force-pushed the swc-2212/migrate-action-group branch from da08b85 to 49fb3e7 Compare June 25, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Component:Action group Status:WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants