docs(toast): accessibility migration analysis#6442
Conversation
|
Coverage Report for CI Build 28254101860Coverage remained the same at 96.246%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
cdransf
left a comment
There was a problem hiding this comment.
Looks great! Left one tiny suggestion. ✨
| None | ||
|
|
5t3ph
left a comment
There was a problem hiding this comment.
Blocking to discuss following React's lead with a "Toast Container" format vs. just the individual Toast component.
|
|
||
| ### What it is not | ||
|
|
||
| Not a dialog, alert dialog, or replacement for critical error messaging. Toasts should not contain actions the user must take to complete a task. If a user must confirm, acknowledge, or act before continuing, use a dialog component instead. |
There was a problem hiding this comment.
Unfortunately, I don't think it's realistic to say Toasts can't contain actions (and design expects them to handle actions). However, it's limited to one action.
See this thread which Michael Jordan weighed in on, although it would partly require we provide a toast container like React does. Maybe something to bring to sync on whether we should own full Toast display/positioning or just provide the base component? One thing the container offers is the ability to better handle the live announcements, which may get muddled if each Toast independently manages it. Plus ability to manage focus within the group and on dismiss.
…nikkimk/swc-2256-toast-a11y
Description
In
CONTRIBUTOR-DOCS/03_project-planning/03_components/toast/accessibility-migration-analysis.md:aria-hiddenwhen closed, and action-button-plus-auto-dismiss hazardrole="status"prescribed as the fixed host role (change from 1st-gen's innerrole="alert")role="alert"on inner.bodydiv), timeout handling, focus-pause behavior, and existing test coverageMotivation and context
The 2nd-gen migration is an opportunity to address known accessibility gaps, align with the latest WAI-ARIA Authoring Practices, and ensure the component meets WCAG 2.2 AA compliance.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Review the Toast accessibility migration analysis