Skip to content

feat(popover): scaffold 2nd-gen component (phase 2 setup)#6353

Closed
rubencarvalho wants to merge 1 commit into
ruben/popover-migrationfrom
ruben/feat-popover-setup-swc-1993
Closed

feat(popover): scaffold 2nd-gen component (phase 2 setup)#6353
rubencarvalho wants to merge 1 commit into
ruben/popover-migrationfrom
ruben/feat-popover-setup-swc-1993

Conversation

@rubencarvalho

Copy link
Copy Markdown
Contributor

Description

Phase 2 (Setup) of the Popover 1st-gen → 2nd-gen migration (Epic SWC-1993). Scaffolds the core + SWC structure so the component builds and registers — no behavior yet.

  • core: PopoverBase property-surface stub, Popover.types (re-exports Placement from the PlacementController), and resolve-trigger / dismissible-stack util stubs wired into utils/index + package.json
  • swc: Popover render stub (branches <div popover="auto"> for non-modal vs <dialog> for modal on the modal attribute), popover.css stub, swc-popover element registration, and empty-but-valid stories/ + test/ scaffolds (3/3 pass in the vitest storybook project)

Motivation and context

First implementation phase after the migration plan. The component build auto-discovers via glob and core exposes per-component package.json exports, so no central manifest changes were needed. See CONTRIBUTOR-DOCS/03_project-planning/03_components/popover/migration-plan.md.

Related issue(s)

  • Epic SWC-1993

Notes

  • Targets the ruben/popover-migration integration branch, not main.
  • Opened as draft (WIP); mark ready when reviewed.

Accessibility testing checklist

Scaffolding only — no interactive behavior is wired yet (the host renders a closed popover).

  • Keyboard — no focusable behavior in this phase; nothing to trap or activate. Keyboard handling lands in Phase 4 (a11y).
  • Screen reader — no roles, names, or ARIA relationships are asserted yet; trigger-side ARIA wiring lands in Phase 4. Full a11y testing will be documented in the a11y and testing phases.

Set up the core and SWC structure for the <swc-popover> migration:

- core: PopoverBase property-surface stub, Popover.types (re-exports
  Placement from the placement-controller), plus resolve-trigger and
  dismissible-stack util stubs wired into utils/index and package.json
- swc: Popover render stub branching <div popover="auto"> (non-modal) vs
  <dialog> (modal), popover.css stub, swc-popover registration, and
  empty-but-valid stories + test scaffolds (3/3 vitest storybook pass)
- plan: record div/dialog render decision, mark container-padding,
  should-flip and tip-padding @internal, arrow positioning in v1 scope,
  and check off the Setup phase; update workstream status table
@changeset-bot

changeset-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ffc865a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6353

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rubencarvalho

Copy link
Copy Markdown
Contributor Author

Consolidated into #6354 (scaffold + API contract). #6354's diff already contained the Setup commit, so review the foundation there. The setup branch remains in the chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant