Fix over-eager rebuilding of rosrust_msg when nothing changed#201
Open
DomWilliamsEE wants to merge 1 commit into
Open
Fix over-eager rebuilding of rosrust_msg when nothing changed#201DomWilliamsEE wants to merge 1 commit into
DomWilliamsEE wants to merge 1 commit into
Conversation
|
Why has this not been merged so far? |
|
@adnanademovic Could you check this PR and merge it? |
Owner
|
Wouldn't this introduce the opposite problem where updates to the I'd be OK with explicitly filtering out any |
DomWilliamsEE
force-pushed
the
master
branch
from
c98f32b to
145f2ef
Compare
Author
|
How about skipping hidden dirs then? Includes |
DomWilliamsEE
force-pushed
the
master
branch
from
145f2ef to
c98f32b
Compare
DomWilliamsEE
force-pushed
the
master
branch
from
c98f32b to
7cfc4f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176, where all files including inside .git are tracked by build.rs and triggers rebuilds too often.