Read the ROSCONSOLE_FORMAT env var to format the logs#174
Open
romainreignier wants to merge 2 commits into
Open
Read the ROSCONSOLE_FORMAT env var to format the logs#174romainreignier wants to merge 2 commits into
romainreignier wants to merge 2 commits into
Conversation
Contributor
Author
|
Note that I did not add test because I do not know how to capture |
To avoid unneeded computations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a naive approach, not much optimized because each call to
String::replace()will allocate a newString, a bit like therospyimplementation.I did not implement the tokens for which the value were not already available. This can be done later.
The new
thread-iddependency should not bring too much new dependencies as it only requireslibcon Linux for example.I have added a space to
INFOandWARNlevel strings so all levels have the same string length.I did this to mimic rosconsole.
But I have just noticed that on the
noetic-develbranch, not yet released, the spaces are gone thanks to this PR ros/rosconsole#52I personally prefer the space so the logs are well aligned.
To implement several loggers, we would need a more advanced logging system. Did you try to use the existing rust
logecosystem and create arosrustbackend for it?