Skip to content

Ember: pulse effect ignores prefers-reduced-motion — bypass animation for reduced motion users#702

Draft
adhamhaithameid wants to merge 1 commit into
mainfrom
ember/pulse-effect-prefers-reduced-motion-17849224627037471505
Draft

Ember: pulse effect ignores prefers-reduced-motion — bypass animation for reduced motion users#702
adhamhaithameid wants to merge 1 commit into
mainfrom
ember/pulse-effect-prefers-reduced-motion-17849224627037471505

Conversation

@adhamhaithameid

Copy link
Copy Markdown
Owner

🔥 Ember — Extension UX Micro-Improvements

Agent: Ember | Day: Wednesday | Date: 2026-01-24


🔥 UX Finding

The pulse effect in triggerPulseEffect (used for comment/edit/both badges) was ignoring user's system accessibility setting for prefers-reduced-motion.

👤 User Impact

Users with vestibular disorders must not be subjected to motion they didn't ask for. Currently, the pulse effect ignores their OS-level preferences, leading to a jarring and inaccessible experience.

🔧 Improvement Applied

Added a matchMedia('(prefers-reduced-motion: reduce)') check in triggerPulseEffect to return early and skip the pulse animation, conforming to WCAG 2.1 AA 2.3.3. Safely wrapped the check with typeof window.matchMedia === 'function' to avoid crashing in JSDOM environments.

✅ Verification

  • Ran Vitest content-pulse suite.
  • Built extension (pnpm run build).
  • Ran smoke tests (pnpm run test:smoke).

📋 Notes

Also added an entry to .jules/ember.md.


PR created automatically by Jules for task 17849224627037471505 started by @adhamhaithameid

Added a `matchMedia('(prefers-reduced-motion: reduce)')` check in `triggerPulseEffect` to return early and skip the pulse animation for users who prefer reduced motion. This conforms to WCAG 2.1 AA 2.3.3 accessibility guidelines.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
extension/entrypoints/content/pulse-effect.ts 50.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant