feat: update to detray version 1.0.0#1289
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
5a544f7 to
3979ded
Compare
2b84101 to
b0b2cb7
Compare
krasznaa
left a comment
There was a problem hiding this comment.
Is there a PR for the Detray changes open? I suppose it would be easiest to see the ITk code generation there. It would also be easiest to make comments about the Detray CMake code there. 🤔
|
P.S. The type/variable name changes are of course a non-issue. Those all look fine. It's the metadata generation that makes or breaks this PR. 😛 |
|
This is the corresponding detray PR acts-project/detray#989. |
0209cd5 to
c5afe0e
Compare
The cmake is much cleaner now, thanks |
c5afe0e to
567fb11
Compare
567fb11 to
ea763e4
Compare
krasznaa
left a comment
There was a problem hiding this comment.
Don't see anything technically wrong here. 🤔 As long as the code works as it should, we could go for this.
|
Performance summaryHere is a summary of the performance effects of this PR: GraphicalTabular
Important All metrics in this report are given as reciprocal throughput, not as wallclock runtime. Note This is an automated message produced upon the explicit request of a human being. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298341 to 298341 (+0.0%) Track finding performanceTotal number of found tracks went from 50220 to 50221 (+0.0%) Track fitting performanceSeeding to track finding relative performanceNote This is an automated message produced on the explicit request of a human being. |
* Update to detray version 0.113.0 * Add device log level option to readme --------- Co-authored-by: Stephen Nicholas Swatman <stephen.nicholas.swatman@cern.ch>

































Contains the renaming and metadata generation