Skip to content

feat: update to detray version 1.0.0#1289

Merged
stephenswat merged 3 commits into
acts-project:mainfrom
niermann999:detray-update
Apr 22, 2026
Merged

feat: update to detray version 1.0.0#1289
stephenswat merged 3 commits into
acts-project:mainfrom
niermann999:detray-update

Conversation

@niermann999

@niermann999 niermann999 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Contains the renaming and metadata generation

@stephenswat

This comment was marked as outdated.

@krasznaa krasznaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PR for the Detray changes open? I suppose it would be easiest to see the ITk code generation there. It would also be easiest to make comments about the Detray CMake code there. 🤔

Comment thread .github/workflows/builds.yml Outdated
Comment thread core/include/traccc/geometry/detector_metadata.hpp.in Outdated
Comment thread core/CMakeLists.txt Outdated
Comment thread extern/detray/CMakeLists.txt Outdated
@krasznaa

Copy link
Copy Markdown
Member

P.S. The type/variable name changes are of course a non-issue. Those all look fine. It's the metadata generation that makes or breaks this PR. 😛

@niermann999 niermann999 marked this pull request as draft April 20, 2026 09:37
@niermann999

Copy link
Copy Markdown
Contributor Author

This is the corresponding detray PR acts-project/detray#989.

@niermann999 niermann999 force-pushed the detray-update branch 2 times, most recently from 0209cd5 to c5afe0e Compare April 20, 2026 14:01
@niermann999 niermann999 marked this pull request as ready for review April 20, 2026 14:01
@niermann999 niermann999 marked this pull request as draft April 20, 2026 14:01
@niermann999 niermann999 requested a review from krasznaa April 20, 2026 14:02
@niermann999

Copy link
Copy Markdown
Contributor Author

P.S. The type/variable name changes are of course a non-issue. Those all look fine. It's the metadata generation that makes or breaks this PR. 😛

The cmake is much cleaner now, thanks

@niermann999 niermann999 marked this pull request as ready for review April 20, 2026 14:15
@niermann999 niermann999 marked this pull request as draft April 20, 2026 14:16
@niermann999 niermann999 marked this pull request as ready for review April 21, 2026 09:33
@niermann999 niermann999 changed the title feat: update to detray version 0.113.0 feat: update to detray version 1.0.0 Apr 21, 2026

@krasznaa krasznaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything technically wrong here. 🤔 As long as the code works as it should, we could go for this.

@stephenswat stephenswat enabled auto-merge (squash) April 22, 2026 11:10
@stephenswat stephenswat disabled auto-merge April 22, 2026 11:11
@sonarqubecloud

Copy link
Copy Markdown

@stephenswat

Copy link
Copy Markdown
Member

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

KernelReciprocal ThroughputParallelism
a5badf94a0244bDeltaa5badf94a0244b
propagate_to_next_surface5.64 ms5.78 ms2.4%4.374.34
find_tracks1.73 ms1.73 ms0.3%1.841.83
count_doublets812.96 μs816.62 μs0.5%1.611.61
ccl_kernel592.42 μs592.91 μs0.1%1.711.71
count_triplets568.57 μs568.21 μs-0.1%1.021.02
find_doublets532.37 μs536.48 μs0.8%3.083.08
Thrust::sort378.73 μs378.82 μs0.0%7.337.33
find_triplets170.50 μs169.58 μs-0.5%1.311.32
estimate_track_params146.29 μs146.28 μs-0.0%2.682.68
build_tracks124.74 μs124.62 μs-0.1%3.723.71
select_seeds59.30 μs59.17 μs-0.2%1.341.34
populate_grid23.98 μs23.97 μs-0.0%1.221.22
count_grid_capacities22.15 μs22.15 μs0.0%1.221.22
remove_duplicates19.96 μs19.95 μs-0.1%25.6625.63
fill_sorted_measurements16.28 μs16.31 μs0.2%1.131.13
update_triplet_weights14.88 μs14.92 μs0.3%1.271.27
fill_finding_propagation_sort_keys8.76 μs8.76 μs0.1%7.757.75
form_spacepoints8.46 μs8.40 μs-0.7%1.491.49
reduce_triplet_counts5.64 μs5.65 μs0.2%3.083.09
unknown5.02 μs5.03 μs0.3%4.274.27
fill_finding_duplicate_removal_sort_keys1.56 μs1.56 μs-0.1%37.9437.91
Total10.89 ms11.03 ms1.4%3.413.40

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

@stephenswat

Copy link
Copy Markdown
Member

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --conditions-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298341 to 298341 (+0.0%)

Seeding plots



Track finding performance

Total number of found tracks went from 50220 to 50221 (+0.0%)

Finding plots









Track fitting performance

Fitting plots














Seeding to track finding relative performance

Seeding to track finding plots



Note

This is an automated message produced on the explicit request of a human being.

@stephenswat stephenswat enabled auto-merge (squash) April 22, 2026 11:57
@stephenswat stephenswat merged commit 1d32a5b into acts-project:main Apr 22, 2026
25 of 27 checks passed
mimodekjaer pushed a commit to mimodekjaer/traccc that referenced this pull request Apr 27, 2026
* Update to detray version 0.113.0

* Add device log level option to readme

---------

Co-authored-by: Stephen Nicholas Swatman <stephen.nicholas.swatman@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants