refactor: Pull out EigenDecomposition printer#5616
Merged
paulgessinger merged 1 commit intoJun 29, 2026
Conversation
paulgessinger
force-pushed
the
refactor/eigen-decomp-string
branch
from
cbf561a to
0e6a310
Compare
Contributor
junggjo9
reviewed
Jun 25, 2026
junggjo9
left a comment
junggjo9
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks. Again what learned that templating is not always the fastest solution in terms of compilation time :)
Member
Author
|
@junggjo9 can you approve? |
junggjo9
previously approved these changes
Jun 29, 2026
This is used in a number of tests, notable the StrawLineFitter test and dominates compilation time and memory usage.
paulgessinger
force-pushed
the
refactor/eigen-decomp-string
branch
from
0e6a310 to
52a5c0f
Compare
acts-policybot
Bot
dismissed
junggjo9’s stale review
Invalidated by push of 52a5c0f
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used in a number of tests, notable the StrawLineFitter test and dominates compilation time and memory usage.