Skip to content

feat: ActsExamples - Column based Muon space point container#5612

Draft
junggjo9 wants to merge 5 commits into
acts-project:mainfrom
junggjo9:GpuStudenPrep
Draft

feat: ActsExamples - Column based Muon space point container#5612
junggjo9 wants to merge 5 commits into
acts-project:mainfrom
junggjo9:GpuStudenPrep

Conversation

@junggjo9

@junggjo9 junggjo9 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor
  • JSON deserialization of the straws lead to an exception -> fixed
  • Add hook that detects whether a JSON file is passed instead of the deserialized JSON
    --- END COMMIT MESSAGE ---
    Tagging @benjaminhuth

@github-actions github-actions Bot added this to the next milestone Jun 22, 2026
@github-actions github-actions Bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Jun 22, 2026
Comment thread Plugins/Json/src/TrackingGeometryJsonConverter.cpp Outdated
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

📊: Physics performance monitoring for 693baee

Full contents

physmon summary

❗️: Downstream build failure

  • eic-shell EICrecon (cc @acts-project/epic-contacts)

@paulgessinger paulgessinger changed the title fix; TrackingGeometry from JSON - Fix deserialization from straws fix: TrackingGeometry from JSON - Fix deserialization from straws Jun 23, 2026

@paulgessinger paulgessinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few unrelated changes.

Comment thread Examples/Io/Root/src/RootMuonSpacePointReader.cpp
Comment thread Examples/Io/Root/src/RootMuonSpacePointWriter.cpp
Comment thread Plugins/Json/src/TrackingGeometryJsonConverter.cpp Outdated
Comment thread Python/Plugins/src/Json.cpp Outdated
@github-actions github-actions Bot removed the Component - Plugins Affects one or more Plugins label Jun 24, 2026
@junggjo9 junggjo9 changed the title fix: TrackingGeometry from JSON - Fix deserialization from straws feat: ActsExamples - Column based Muon space point container Jun 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions github-actions Bot added Component - Core Affects the Core module Event Data Model labels Jun 25, 2026
Comment on lines +156 to +162
mutable MuonSpacePoint::MuonId m_idCache{};
mutable Acts::GeometryIdentifier m_geometryIdCache{};
mutable Acts::Vector3 m_localPositionCache{Acts::Vector3::Zero()};
mutable Acts::Vector3 m_sensorDirectionCache{Acts::Vector3::Zero()};
mutable Acts::Vector3 m_toNextSensorCache{Acts::Vector3::Zero()};
mutable Acts::Vector3 m_planeNormalCache{Acts::Vector3::Zero()};
mutable std::array<double, 3> m_covarianceCache{0.0, 0.0, 0.0};

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that mean that the container can only be accessed by one thread?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants