chore: DevContainer / VSCode improvements#5611
Conversation
github-actions
Bot
added
Component - Core
paulgessinger
force-pushed
the
chore/vscode-support
branch
from
4513f36 to
2404432
Compare
github-actions
Bot
removed
Component - Core
krasznaa
left a comment
krasznaa
left a comment
There was a problem hiding this comment.
I'm all for perking up the DevContainer config a little. Since making a proper development environment for Acts has been a bit challenging to me as well in the past.
I don't see anything deal-breaking here. I'm mainly wondering if we could simplify the configuration a little further. 🤔
| }, | ||
| "containerEnv": { | ||
| "CXXFLAGS": "-Wno-psabi" | ||
| "CXXFLAGS": "-Wno-psabi", |
There was a problem hiding this comment.
Where does this come from? 😕 It has a weird smell that we'd need to turn off a specific warning like this.
There was a problem hiding this comment.
Yeah this is annoying. The origin is a warning on aarch64 GCC that just tells you that the compiler/stdlib changed their ABI for std::pair (IIRC) at some point. From all of my research, this is not associated with any code pattern or code defect in particular, it's just that if you use std::pair as a function argument in GCC on aarch64, it will tell you that the ABI changed back in GCC10 or so. As far as I've been able to work out, this is not actionable from our side.
There was a problem hiding this comment.
Yeah, that ARM warning has been the bane of me in some cases as well... 😦 I think you're right, this is as good a "solution" for it as we can get.
| RUN uv tool install --no-cache pre-commit | ||
| RUN uv tool install -U --no-cache --no-build --force uv | ||
|
|
||
| RUN uv tool install --no-build --no-cache prek |
There was a problem hiding this comment.
SonarCloud may have a point here. 🤔
|
@krasznaa can you have another lok now? |
krasznaa
left a comment
krasznaa
left a comment
There was a problem hiding this comment.
Sorry for the silence. Yeah, I don't think we can do much better than this. 😉
| }, | ||
| "containerEnv": { | ||
| "CXXFLAGS": "-Wno-psabi" | ||
| "CXXFLAGS": "-Wno-psabi", |
There was a problem hiding this comment.
Yeah, that ARM warning has been the bane of me in some cases as well... 😦 I think you're right, this is as good a "solution" for it as we can get.
|
2 participants
This pull request updates the development container setup to improve CMake integration, environment configuration, and pre-commit hook management. The main changes include switching from
pre-committoprekfor git hooks, enhancing CMake support in VS Code, and improving environment consistency and caching for builds.Dev environment improvements:
pre-committoprekin the Dockerfile and updated documentation to useprek installfor enabling git hooks. (.devcontainer/Dockerfile,.devcontainer/setup.sh) [1] [2].devcontainer/setup.sh)CMake and VS Code integration:
ms-vscode.cmake-toolsextension and updated VS Code settings to set the default CMake preset todevcontainer, configure test environment variables, and improve test output handling. (.devcontainer/devcontainer.json)devcontainerCMake preset for consistent builds inside the container. (CMakePresets.json)Environment and caching enhancements:
LC_ALL,LANG,CCACHE_DIR) and mounted a named volume for ccache to speed up rebuilds and ensure locale consistency. (.devcontainer/devcontainer.json)