feat: Add optional time-of-flight cuts to Seeding2 doublet finding and seed filtering#5610
Draft
jburzy wants to merge 1 commit into
Draft
feat: Add optional time-of-flight cuts to Seeding2 doublet finding and seed filtering#5610jburzy wants to merge 1 commit into
jburzy wants to merge 1 commit into
Conversation
… filtering Use the per-space-point time to reject combinations that are inconsistent with a particle travelling from the interaction point at the speed of light. - DoubletSeedFinder: new Config fields deltaTMax and tofInverseSpeed. A doublet is rejected when |(t_other - t_middle) - (L_other - L_middle) * tofInverseSpeed| exceeds deltaTMax, with L = sqrt(r^2 + z^2). - BroadTripletSeedFilter: the same deltaTMax / tofInverseSpeed cut applied to a triplet's bottom and top space points. deltaTMax defaults to infinity (no cut) and the cut is only evaluated when the space-point container provides a time column, so seeding without time behaves exactly as before.
jburzy
changed the title
Contributor
Author
|
Looks like maybe this is a duplicate of #5524... will leave open for now but feel free to close if the other implementation is preferred |
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the per-space-point time to reject combinations that are inconsistent with a particle travelling from the interaction point at the speed of light.
deltaTMax defaults to infinity (no cut) and the cut is only evaluated when the space-point container provides a time column, so seeding without time behaves exactly as before.
--- END COMMIT MESSAGE ---
This is meant for 4D trackers to improve CPU performance by rejecting spurious doublet combinations early in the chain.