fix: preserve stream state in surface output#5589
Conversation
hadronic-arvind
force-pushed
the
codex/to-stream-ostream-state
branch
from
864d479 to
d6dc2d9
Compare
|
Could a maintainer please rerun merge-sentinel / trigger the required CI for this PR ? Current head is
Local validation for this head passed:
Thanks! |
|
/ci-bridge-run |
| std::ostream& m_stream; | ||
| std::ios_base::fmtflags m_flags; | ||
| std::streamsize m_precision; | ||
| std::streamsize m_width; | ||
| char m_fill; |
There was a problem hiding this comment.
| std::ostream& m_stream; | |
| std::ios_base::fmtflags m_flags; | |
| std::streamsize m_precision; | |
| std::streamsize m_width; | |
| char m_fill; | |
| std::ostream* m_stream{}; | |
| std::ios_base::fmtflags m_flags{}; | |
| std::streamsize m_precision{}; | |
| std::streamsize m_width{}; | |
| char m_fill{}; |
std::ostream* m_streammore a matter of taste but ref members are a bit annoying sometimes- I would init all the fields for safety
There was a problem hiding this comment.
I wonder if this should rather go into some detail/ directory and namespace. I don't think we want to ship this as public API
There was a problem hiding this comment.
Got it. Will wait for the checks to be completed, make these changes and update the PR.
|
3 participants
Refs #3079
Summary
OstreamStateGuardto restorestd::ostreamflags, precision, width, and fill after formatted output.toStream/operator<<paths for surface bounds, volume bounds,Surface,SurfaceArray,PerigeeSurface, and GSF component merging output.Validation
docker exec 7c8454e52c16 cmake --build /workspaces/acts/build_codex --target ActsUnitTestSurfaceBounds ActsUnitTestSurface ActsUnitTestSurfaceArray ActsUnitTestPerigeeSurface ActsUnitTestVolumeBounds ActsUnitTestGsfComponentMerging ActsCore_HEADERS -j 4docker exec 7c8454e52c16 ctest --test-dir /workspaces/acts/build_codex -R "^(SurfaceBounds|Surface|SurfaceArray|PerigeeSurface|VolumeBounds|GsfComponentMerging)$" --output-on-failurepre-commithook suite on the amended commit