Skip to content

(feat) Rootless dind mode #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexrecuenco wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

(feat) Rootless dind mode #4541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion charts/gha-runner-scale-set/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ volumeMounts:
{{- end }}

{{- define "gha-runner-scale-set.dind-container" -}}
image: docker:dind
{{- $rootless := and .Values.containerMode (.Values.containerMode.rootless) }}
image: {{ if $rootless }}docker:dind-rootless{{ else }}docker:dind{{ end }}
Comment on lines +113 to +114
args:
- dockerd
- --host=unix:///var/run/docker.sock
Expand All @@ -119,7 +120,15 @@ env:
- name: DOCKER_GROUP_GID
value: "123"
securityContext:
{{- if $rootless }}
privileged: false
appArmorProfile:
type: Unconfined
seccompProfile:
type: Unconfined
{{- else }}
privileged: true
{{- end }}
Comment on lines +123 to +131
{{- if (ge (.Capabilities.KubeVersion.Minor | int) 29) }}
restartPolicy: Always
startupProbe:
Expand Down
4 changes: 4 additions & 0 deletions charts/gha-runner-scale-set/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ githubConfigSecret:
## empty, and configuration should be applied to the template.
# containerMode:
# type: "dind" ## type can be set to "dind", "kubernetes", or "kubernetes-novolume"
# ## When containerMode.type=dind, set rootless to true to run the dind container
# ## using the "docker:dind-rootless" image without privileged mode. The dind
# ## container instead runs with an Unconfined AppArmor and seccomp profile.
# rootless: false
Comment on lines +121 to +124
# ## the following is required when containerMode.type=kubernetes
# kubernetesModeWorkVolumeClaim:
# accessModes: ["ReadWriteOnce"]
Expand Down