Add ensemble learning to package#74
Open
NickT42 wants to merge 3 commits into
Open
Conversation
The function 'build_ensemble' was added, which provides Random-Forest-Like training of a series of submodels. In addition, missing alphabet() - related functions such as atoms() and connectives() were added for the 'DecisionList' type
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 56.37% 54.62% -1.76%
==========================================
Files 20 21 +1
Lines 1254 1307 +53
==========================================
+ Hits 707 714 +7
- Misses 547 593 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to add support for the build_ensemble function, which has been moved from the pull request in 'ModalDecisionLists.jl' to here as it's more fitting to the 'SoleModels.jl' package.
The other changes include
Note that the slicing in the new apply function currently risks causing issues if the tabulardataset in the propositional logiset on which the ensemble is to be applied does not support all '__getindex()' features, but that is a problem to be solved by having stricter prerequisites for the table in 'PropositionalLogiset'.