Repository navigation
Add integration test for fan portfolio endpoint excluding creators where the wallet holds zero keys #645
Description
Summary
The fan portfolio endpoint aggregates a wallet's holdings but should exclude any creator where the current holding quantity is zero (e.g. after a full sell). An integration test should seed a zero-quantity holding and confirm it is absent from the portfolio response.
Scope
- Seed wallet A with 2 keys for creator X and 0 keys for creator Y (simulating a full sell that left a zero record)
- Call the fan portfolio endpoint for wallet A
- Assert creator X is present with
quantity: 2 - Assert creator Y is absent from the response
Acceptance Criteria
- Creator with zero holding excluded from portfolio response
- Creator with non-zero holding present with correct quantity
-
grand_totalreflects only non-zero holdings - Response does not error when zero-quantity records exist in the database
ETA: 12 hours
Coordinate on Telegram
Activity
wagmiiii commentedon Jul 25, 2026
@wagmiiii has applied to work on this issue as part of the Stellar Wave Program's 7th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @wagmiiii to this issue.
ZeePearl56 commentedon Jul 25, 2026
@ZeePearl56 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @ZeePearl56 to this issue.
abimbolaalabi commentedon Jul 25, 2026
@abimbolaalabi has applied to work on this issue as part of the Stellar Wave Program's 7th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @abimbolaalabi to this issue.
teethaking commentedon Jul 25, 2026
@teethaking has applied to work on this issue as part of the Stellar Wave Program's 7th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @teethaking to this issue.
Caneryy commentedon Jul 25, 2026
@Caneryy has applied to work on this issue as part of the Stellar Wave Program's 7th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Caneryy to this issue.
edehvalentine236-jpg commentedon Jul 25, 2026
@edehvalentine236-jpg has applied to work on this issue as part of the Stellar Wave Program's 7th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @edehvalentine236-jpg to this issue.
drips-wave commentedon Jul 25, 2026
Congratulations, @edehvalentine236-jpg! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.
🧑💻 @edehvalentine236-jpg: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Sep 30, 2026
🎉 This issue has been marked as completed on GrantFox!
@edehvalentine236-jpg's PR #1005 was approved and merged by @Chucks1093.
🏆 @edehvalentine236-jpg: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (105 total points). Track your full progress on GrantFox.
👏 Great work, @edehvalentine236-jpg! Keep contributing to accesslayerorg.
drips-wave commentedon Sep 30, 2026
This issue has been completed by @edehvalentine236-jpg as part of the Stellar Wave Program's 9th Wave 🥳
😎 @edehvalentine236-jpg: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.