Internal Timeout in GlobusExchangeTransport#394
Merged
Conversation
cbc4ef3 to
8661202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the GlobusExchangeTransport relied on waiting on receive indefinitely for a message. This causes problems when connections timeout (i.e. because of site of nginx policies). The ideal solution would be to move to SSE (#393) but this is blocked a bug within the globus_sdk. This PR is a temporary patch so that we can move forward with enforcing a maximum timeout in the cloud exchange (#390). This PR essentially allows the GlobusExchangeTransport to deal with timeouts gracefully.
Related Issues
Changes
Testing
N/A
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).