Run test suite on MacOS (arm64 only)#220
Conversation
655a974 to
3967bd2
Compare
|
I think the hangs in the unit tests are related to #213. Odd that it hangs rather than crashing like on linux though. I occasionally observe the hang locally and interrupting the process produced this stack trace: |
In my (linux based) local dev reproduction, I see quasi-hangs: it sits for almost exactly 120s before exiting, which is slower than I'd expect for a properly handled error. |
3967bd2 to
2830be2
Compare
|
The unit tests run ok locally for me now after rebasing to incorporate #225. Can't reproduce the hang anymore but something still does on the runner. |
|
I had a play around with this in PR #228. In that PR, the tests take 17 minutes before failing, which is longer than the 10 minute maximum time specified for this test. There's a couple of obvious recommendations there: make that timeout longer, make the tests faster. Then, more interestingly, there is a pile of non-timeout failures only the 3.11 runner I ended up with, that all seem ultimately to be: that is, you can't necessarily look up the hostname that the host is reporting for itself. even though that's arguably a misconfiguration of the host environment. The other runners passed all the tests though. Here's the test run https://github.com/academy-agents/academy/actions/runs/18527756889/job/52802488866?pr=228 |
|
(in a different test run, a different set of macos runners manifested that same hostname error) |
|
The other day I upgraded proxystore from This is possibly related: actions/setup-python#1223 One run still failed with |
|
On the suspicious runners, I see that the hostname looks like this: On a working runner, I see that the hostname and /etc/hosts entry align. That is consistent with the |
|
i added an /etc/hosts to PR #228 to validate that fixing /etc/hosts makes this stuff work. I'm not advocating for that to be included in the test setup, but it's an option. |
|
Looks like this issue tracks the This PR isn't that important so I'm okay sitting on it for a bit to see if there's any progress on actions/runner-images#12562 and actions/setup-python#1223. If it takes too long to get fixed then we can merge with |
12514fa to
b5edf24
Compare
b5edf24 to
5a9d238
Compare
Summary
I think it's time to enable CI testing on MacOS since that's commonly used for development. I hadn't enabled it initially when we were moving fast with development, but fortunately it works okay.
Related Issues
N/A
Changes
Testing
N/A
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).